Обсуждение: pgadmin 1.10.5 crash

Hi,
I am using Ubuntu 10.10 i386, Postgres 8.4.7, and pgAdmin 1.10.5 that
come in ubuntu repos. I have a non-super db user which can create dbs
and roles. Steps to reproduce crash:

run pgAdmin
choose the local pg server and login
select your user's database, or any suitable one
click on sql editor button in the toolbar
paste:
CREATE TABLE empsal
(
  dep varchar(3),
  empno integer,
  sal real
);
insert into empsal values ('dev', 22, 123.45);

select the empsal table
click on the View Data button on the toolbar
a guru hint is displayed about non-existing primary keys, click OK
u see the single row u just inserted
click on the last cell (the sal cell is selected)
press 'Enter'
pgAdmin crashes!

I am not sure if this is fixed in later versions of pgAdmin, but I
would be greatful if it is fixed in the 1.10 branch, because I am
stuck with pg 8.4 and pga 1.10.

Thanks,
Serhat

Le 27/02/2011 18:05, Serhat Sevki Dincer a écrit :
> Hi,
> I am using Ubuntu 10.10 i386, Postgres 8.4.7, and pgAdmin 1.10.5 that
> come in ubuntu repos. I have a non-super db user which can create dbs
> and roles. Steps to reproduce crash:
>
> run pgAdmin
> choose the local pg server and login
> select your user's database, or any suitable one
> click on sql editor button in the toolbar
> paste:
> CREATE TABLE empsal
> (
>   dep varchar(3),
>   empno integer,
>   sal real
> );
> insert into empsal values ('dev', 22, 123.45);
>
> select the empsal table
> click on the View Data button on the toolbar
> a guru hint is displayed about non-existing primary keys, click OK
> u see the single row u just inserted
> click on the last cell (the sal cell is selected)
> press 'Enter'
> pgAdmin crashes!
>
> I am not sure if this is fixed in later versions of pgAdmin, but I
> would be greatful if it is fixed in the 1.10 branch, because I am
> stuck with pg 8.4 and pga 1.10.
>

Fixed in 1.12.2+ and 1.13+. Not sure when though.

Unfortunately, there'll be no fix for 1.10. We don't have the manpower
to work on so old releases.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

> Fixed in 1.12.2+ and 1.13+. Not sure when though.
>
> Unfortunately, there'll be no fix for 1.10. We don't have the manpower
> to work on so old releases.

It is just the previous "so old" stable release. This excludes the
whole debian-ish world from this needed fix (assuming downloading the
source and building it is no fun for normal users. see
packages.debian.org and packages.ubuntu.com, they all have 1.10.5).
Maybe if you can point out the specific git commit fixing this, I will
try to get this included into debian/ubuntu. Or even I could help
maintain the 1.10 branch?

Thanks..

Le 05/03/2011 19:59, Serhat Sevki Dincer a écrit :
>> Fixed in 1.12.2+ and 1.13+. Not sure when though.
>>
>> Unfortunately, there'll be no fix for 1.10. We don't have the manpower
>> to work on so old releases.
>
> It is just the previous "so old" stable release.

Which means two years old. And I know it's kind of weird but we already
have issues maintaining the stable one, so I won't even look at the
previous stable one.

> This excludes the
> whole debian-ish world from this needed fix (assuming downloading the
> source and building it is no fun for normal users. see
> packages.debian.org and packages.ubuntu.com, they all have 1.10.5).

I know all that, and it doesn't please me. But I don't know how to do
otherwise.

> Maybe if you can point out the specific git commit fixing this, I will
> try to get this included into debian/ubuntu. Or even I could help
> maintain the 1.10 branch?
>

I don't have the specific git commit. I searched a bit in the CHANGELOG
and the "git log", but didn't find what I was looking for. With a bit of
"git bisect", you may find it easily.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

I have prepared and tested a patch, and submitted to ubuntu for the interested.
thx

https://bugs.launchpad.net/ubuntu/+source/pgadmin3/+bug/730235