Обсуждение: Support for unlogged tables

Hi,

This 9.1 new feature is supported with this patch. It takes care of the
table property tab, table dialog, and pg_dump window.

Comments?


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> Hi,
>
> This 9.1 new feature is supported with this patch. It takes care of the
> table property tab, table dialog, and pg_dump window.
>
> Comments?

Haven't tried building it, but this looks weird:

-    EVT_CHECKBOX(XRCID("chkHasOids"),               dlgProperty::OnChange)
+    EVT_CHECKBOX(XRCID("chkUnlogged"),               dlgProperty::OnChange)


should it really move the HasOids one?


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Le 31/12/2010 12:43, Magnus Hagander a écrit :
> On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> Hi,
>>
>> This 9.1 new feature is supported with this patch. It takes care of the
>> table property tab, table dialog, and pg_dump window.
>>
>> Comments?
>
> Haven't tried building it, but this looks weird:
>
> -    EVT_CHECKBOX(XRCID("chkHasOids"),               dlgProperty::OnChange)
> +    EVT_CHECKBOX(XRCID("chkUnlogged"),               dlgProperty::OnChange)
>
>
> should it really move the HasOids one?
>
>

Yes. I don't know why but we had two lines with chkHasOids, that both
called dlgProperty::OnChange when there is an event on the checkbox.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

On Fri, Dec 31, 2010 at 15:07, Guillaume Lelarge <guillaume@lelarge.info> wrote:
> Le 31/12/2010 12:43, Magnus Hagander a écrit :
>> On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>> Hi,
>>>
>>> This 9.1 new feature is supported with this patch. It takes care of the
>>> table property tab, table dialog, and pg_dump window.
>>>
>>> Comments?
>>
>> Haven't tried building it, but this looks weird:
>>
>> -    EVT_CHECKBOX(XRCID("chkHasOids"),               dlgProperty::OnChange)
>> +    EVT_CHECKBOX(XRCID("chkUnlogged"),               dlgProperty::OnChange)
>>
>>
>> should it really move the HasOids one?
>>
>>
>
> Yes. I don't know why but we had two lines with chkHasOids, that both
> called dlgProperty::OnChange when there is an event on the checkbox.

Oh. Interesting. :S

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Le 31/12/2010 15:27, Magnus Hagander a écrit :
> On Fri, Dec 31, 2010 at 15:07, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>> Le 31/12/2010 12:43, Magnus Hagander a écrit :
>>> On Fri, Dec 31, 2010 at 00:28, Guillaume Lelarge <guillaume@lelarge.info> wrote:
>>>> Hi,
>>>>
>>>> This 9.1 new feature is supported with this patch. It takes care of the
>>>> table property tab, table dialog, and pg_dump window.
>>>>
>>>> Comments?
>>>
>>> Haven't tried building it, but this looks weird:
>>>
>>> -    EVT_CHECKBOX(XRCID("chkHasOids"),               dlgProperty::OnChange)
>>> +    EVT_CHECKBOX(XRCID("chkUnlogged"),               dlgProperty::OnChange)
>>>
>>>
>>> should it really move the HasOids one?
>>>
>>>
>>
>> Yes. I don't know why but we had two lines with chkHasOids, that both
>> called dlgProperty::OnChange when there is an event on the checkbox.
>
> Oh. Interesting. :S
>

Commited. I know that was a bit quick, but this was an easy one and I
wanted a good start for this new year. I hope this will be good omens :)


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Le 06/01/2011 23:38, Jasmin Dizdarevic a écrit :
> [...]
> I've just build the latest master branch.
> I think there is a problem with the unlogged feature. pgAdmin crashes on
> pgsql 8.4. The problem (access violation) occurs on line 1224:
>
> *if (chkUnlogged->GetValue())*
> sql +=  wxT("UNLOGGED ")
>

Sorry for answering so late, I was quite ill since thursday afternoon.
Anyway, back to your issue. I forgot to update the xrcDialogs.cpp file.
I did the change and pushed it. I also found another bug that I fixed.

Thanks.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com