Обсуждение: #197 copy/paste numeric fields

Поиск
Список
Период
Сортировка

#197 copy/paste numeric fields

От
Steffen Kuhn
Дата:
Hi Dave,

I attached a patch for #197.
Please be so kind to review, if this was all about this issue.

Regards
Steffen


Вложения

Re: #197 copy/paste numeric fields

От
Guillaume Lelarge
Дата:
Le 29/08/2010 18:16, Steffen Kuhn a écrit :
> Hi Dave,
>
> I attached a patch for #197.
> Please be so kind to review, if this was all about this issue.
>

Reviewed, modified a bit, and commited.

Modified because there is an issue with your patch. The issue was that
it replaced all the contents of the textbox. This is not the standard
behaviour. It should replace the selected text if any. If there's no
text selected, it should insert the text at the cursor's position.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Re: #197 copy/paste numeric fields

От
Guillaume Lelarge
Дата:
Le 30/08/2010 13:52, Guillaume Lelarge a écrit :
> Le 29/08/2010 18:16, Steffen Kuhn a écrit :
>> Hi Dave,
>>
>> I attached a patch for #197.
>> Please be so kind to review, if this was all about this issue.
>>
>
> Reviewed, modified a bit, and commited.
>
> Modified because there is an issue with your patch. The issue was that
> it replaced all the contents of the textbox. This is not the standard
> behaviour. It should replace the selected text if any. If there's no
> text selected, it should insert the text at the cursor's position.
>

Oh, and thanks for your patch :)


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com