Обсуждение: configure --with-wx-version=2.6 should error earlier

Running configure --with-wx-version=2.6 succeeds and then bails out during
the build process.  If pgadmin requires 2.8 it should enforce that at
configure time.

Kris Jurka

Kris Jurka wrote:
>
> Running configure --with-wx-version=2.6 succeeds and then bails out
> during the build process.  If pgadmin requires 2.8 it should enforce
> that at configure time.

Agreed - configure check committed to SVN.

Thanks for the report.

Regards Dave.

Dave Page wrote:

> Kris Jurka wrote:
>>
>> Running configure --with-wx-version=2.6 succeeds and then bails out
>> during the build process.  If pgadmin requires 2.8 it should enforce
>> that at configure time.
>
> Agreed - configure check committed to SVN.
>
That broke build process (you couldn't even force specific version) on
Ubuntu Fiesty (and possibly Debian), as one can have more than one
wx-widgets version installed and default wouldn't be necessary the best
one.

In fact, Ubuntu Fiesty defaults to 2.6.x, and so the check used
in ./configure (wx-config --version) gives 2.6.3, where
(wx-config --version=2.8 --version) gives 2.8.1.

So I created really ugly patch (as am really I not into shell scripting, nor
m4 macros), to fix it, but it might not work with non-debian wx-config
versions, so please doublecheck/improve (strongly recommended ! :-).

Well, in fact all major-minor version checking magic might be probably
thrown away, as we are asking wx-config for specific versions anyway.

Ugly (but works-for-me) patch attached.

Dave Page wrote:

> Kris Jurka wrote:
>>
>> Running configure --with-wx-version=2.6 succeeds and then bails out
>> during the build process.  If pgadmin requires 2.8 it should enforce
>> that at configure time.
>
> Agreed - configure check committed to SVN.
>
That broke build process (you couldn't even force specific version) on
Ubuntu Fiesty (and possibly Debian), as one can have more than one
wx-widgets version installed and default wouldn't be necessary the best
one.

In fact, Ubuntu Fiesty defaults to 2.6.x, and so the check used
in ./configure (wx-config --version) gives 2.6.3, where
(wx-config --version=2.8 --version) gives 2.8.1.

So I created really ugly patch (as am really I not into shell scripting, nor
m4 macros), to fix it, but it might not work with non-debian wx-config
versions, so please doublecheck/improve (strongly recommended ! :-).

Well, in fact all major-minor version checking magic might be probably
thrown away, as we are asking wx-config for specific versions anyway.

Ugly (but works-for-me) patch attached.

Leszek Trenkner wrote:
> Dave Page wrote:
>
>> Kris Jurka wrote:
>>> Running configure --with-wx-version=2.6 succeeds and then bails out
>>> during the build process.  If pgadmin requires 2.8 it should enforce
>>> that at configure time.
>> Agreed - configure check committed to SVN.
>>
> That broke build process (you couldn't even force specific version) on
> Ubuntu Fiesty (and possibly Debian), as one can have more than one
> wx-widgets version installed and default wouldn't be necessary the best
> one.

Whoops. Sorry. I've committed a fix for this - please test. It helps
that you can do:

wx-config --version --version=2.8

which will return the full version number for the 2.8 installation.

Thanks, Dave.