Обсуждение: 1.6.3 uploaded

Поиск
Список
Период
Сортировка

1.6.3 uploaded

От
Dave Page
Дата:
I've uploaded 1.6.3 in source, win32 and osx formats to
http://developer.pgadmin.org/ftp/release/v1.6.3. Please take a few
minutes to check them out and report any major issues before I announce.

Cheers, Dave.

Re: 1.6.3 uploaded

От
Dhanaraj M
Дата:
Hi Dave,

The current code dumps the core when the query tool window is closed.
Can you please make the following change?
(I have tested and this works well)
Thanks.

**********src/frm/frmQuery.cpp.orig*************************
void frmQuery::OnChangeConnection(wxCommandEvent &ev)
{
   // On Solaris, this event seems to get fired when the form closes(!!)
!    if(!IsVisible() && !loading)
       return;

   unsigned int sel=cbConnection->GetCurrentSelection();
   if (sel == cbConnection->GetCount()-1)

**********src/frm/frmQuery.cpp*************************
void frmQuery::OnChangeConnection(wxCommandEvent &ev)
{
   // On Solaris, this event seems to get fired when the form closes(!!)
!    if(!IsVisible())
       return;

   unsigned int sel=cbConnection->GetCurrentSelection();
   if (sel == cbConnection->GetCount()-1)

=============================================================

bash-3.00# pstack core
core 'core' of 19756:   pgadmin3
-----------------  lwp# 1 / thread# 1  --------------------
0824ded9 __1cTdlgSelectConnectionCGo6MpnGpgConn_pnOctlComboBoxFix__i_
(8046550, 949d2b8, 963e608) + d6
082b5c1d __1cIfrmQdDuerySOnChangeConnection6MrnOwxCommandEvent__v_
(95c8d90, 8046800, 8046770, 8686ff1, 8b87240, 95c8d90) + 144
086291f2
__1cMwxAppConsoleLHandleEvent6kMpnMwxEvtHandler_m0B_MrnHwxEvent__v4_v_
(8b87240, 95c8d90, 82b5ad9, 0, 8046800, 804683c) + 12
08686ff1
__1cMwxEvtHandlerVProcessEventIfMatches6FrknVwxEventTableEntryBase_p0rnHwxEvent__b_
(8aa5088, 95c8d90, 8046800) + 60
0868681b
__1cQwxEventHashTableLHandleEvent6MrnHwxEvent_pnMwxEvtHandler__b_
(8aa5490, 8046800, 95c8d90) + 5a
086870d9 __1cMwxEvtHandlerMProcessEvent6MrnHwxEvent__b_ (95c8d90,
8046800) + 77
085bfe45 __1cMwxWindowBaseJTryParent6MrnHwxEvent__b_ (963e608, 8046800)
+ 43
0868710b __1cMwxEvtHandlerMProcessEvent6MrnHwxEvent__b_ (963e608,
8046800) + a9
0853aedc gtkcombobox_changed_callback (963ea90, 963e608, 9633d90) + 99
fe1d4c01 g_cclosure_marshal_VOID__VOID () + 51
-----------------  lwp# 2 / thread# 2  --------------------
08684a40 wxPthreadStart(), exit value = 0x00000000
       ** zombie (exited, not detached, not yet joined) **

===============================================================================



Dave Page wrote:

> I've uploaded 1.6.3 in source, win32 and osx formats to
> http://developer.pgadmin.org/ftp/release/v1.6.3. Please take a few
> minutes to check them out and report any major issues before I announce.
>
> Cheers, Dave.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
>               http://archives.postgresql.org

Re: 1.6.3 uploaded - No issues

От
Dhanaraj M
Дата:
Hi Dave,

Sorry for the confusion. As usual, I tested the previously installed
binaries in a hurry.

I tested pgadmin3-1.6.3 in Solaris and it does not dump the core.
The Sun studio patch also works fine.

Thanks
Dhanaraj

Dhanaraj M wrote:
> Hi Dave,
>
> The current code dumps the core when the query tool window is closed.
> Can you please make the following change?
> (I have tested and this works well)
> Thanks.
>
> **********src/frm/frmQuery.cpp.orig*************************
> void frmQuery::OnChangeConnection(wxCommandEvent &ev)
> {
>   // On Solaris, this event seems to get fired when the form closes(!!)
> !    if(!IsVisible() && !loading)
>       return;
>
>   unsigned int sel=cbConnection->GetCurrentSelection();
>   if (sel == cbConnection->GetCount()-1)
>
> **********src/frm/frmQuery.cpp*************************
> void frmQuery::OnChangeConnection(wxCommandEvent &ev)
> {
>   // On Solaris, this event seems to get fired when the form closes(!!)
> !    if(!IsVisible())
>       return;
>
>   unsigned int sel=cbConnection->GetCurrentSelection();
>   if (sel == cbConnection->GetCount()-1)
>
> =============================================================
>
> bash-3.00# pstack core
> core 'core' of 19756:   pgadmin3
> -----------------  lwp# 1 / thread# 1  --------------------
> 0824ded9 __1cTdlgSelectConnectionCGo6MpnGpgConn_pnOctlComboBoxFix__i_
> (8046550, 949d2b8, 963e608) + d6
> 082b5c1d __1cIfrmQdDuerySOnChangeConnection6MrnOwxCommandEvent__v_
> (95c8d90, 8046800, 8046770, 8686ff1, 8b87240, 95c8d90) + 144
> 086291f2
> __1cMwxAppConsoleLHandleEvent6kMpnMwxEvtHandler_m0B_MrnHwxEvent__v4_v_
> (8b87240, 95c8d90, 82b5ad9, 0, 8046800, 804683c) + 12
> 08686ff1
> __1cMwxEvtHandlerVProcessEventIfMatches6FrknVwxEventTableEntryBase_p0rnHwxEvent__b_
> (8aa5088, 95c8d90, 8046800) + 60
> 0868681b
> __1cQwxEventHashTableLHandleEvent6MrnHwxEvent_pnMwxEvtHandler__b_
> (8aa5490, 8046800, 95c8d90) + 5a
> 086870d9 __1cMwxEvtHandlerMProcessEvent6MrnHwxEvent__b_ (95c8d90,
> 8046800) + 77
> 085bfe45 __1cMwxWindowBaseJTryParent6MrnHwxEvent__b_ (963e608,
> 8046800) + 43
> 0868710b __1cMwxEvtHandlerMProcessEvent6MrnHwxEvent__b_ (963e608,
> 8046800) + a9
> 0853aedc gtkcombobox_changed_callback (963ea90, 963e608, 9633d90) + 99
> fe1d4c01 g_cclosure_marshal_VOID__VOID () + 51
> -----------------  lwp# 2 / thread# 2  --------------------
> 08684a40 wxPthreadStart(), exit value = 0x00000000
>       ** zombie (exited, not detached, not yet joined) **
>
> ===============================================================================
>
>
>
> Dave Page wrote:
>
>> I've uploaded 1.6.3 in source, win32 and osx formats to
>> http://developer.pgadmin.org/ftp/release/v1.6.3. Please take a few
>> minutes to check them out and report any major issues before I announce.
>>
>> Cheers, Dave.
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 4: Have you searched our list archives?
>>
>>               http://archives.postgresql.org
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

Re: 1.6.3 uploaded - No issues

От
Dave Page
Дата:
Dhanaraj M wrote:
> Hi Dave,
>
> Sorry for the confusion. As usual, I tested the previously installed
> binaries in a hurry.

I was going to say I thought we'd already fixed that issue last time round!

> I tested pgadmin3-1.6.3 in Solaris and it does not dump the core.
> The Sun studio patch also works fine.

OK, thanks for testing.

Regards Dave