Обсуждение: Bad declaration ?

Hi all,

Without this patch, I'm not able to build pgAdmin. I don't know if I
made something wrong or if this is a real mistake.

Regards.


--
Guillaume.
<!-- http://abs.traduc.org/
      http://lfs.traduc.org/
      http://docs.postgresqlfr.org/ -->
Index: debugger/include/wsCodeWindow.h
===================================================================
--- debugger/include/wsCodeWindow.h    (révision 6089)
+++ debugger/include/wsCodeWindow.h    (copie de travail)
@@ -205,7 +205,7 @@
     static wxString m_commandCreateListener;
     static wxString m_commandWaitForTarget;

-    void wsCodeWindow::OnClose( wxCloseEvent & event );
+    void OnClose( wxCloseEvent & event );

     DECLARE_EVENT_TABLE()
 };

> ------- Original Message -------
> From: Guillaume Lelarge <guillaume@lelarge.info>
> To: pgadmin-hackers@postgresql.org
> Sent: 17/03/07, 00:06:39
> Subject: [pgadmin-hackers] Bad declaration ?
>
> Hi all,
>
> Without this patch, I'm not able to build pgAdmin. I don't know if I
> made something wrong or if this is a real mistake.

The debugger code is new in SVN (as I'm sure you realise) and has only really been tested on VC++ in the past. It
buildson developer, and my Mac, but maybe your compiler is more picky. 

Please go ahead and commit your patch.

/D

Dave Page a écrit :
>> From: Guillaume Lelarge <guillaume@lelarge.info>
>>[...]
>> Without this patch, I'm not able to build pgAdmin. I don't know if I
>> made something wrong or if this is a real mistake.
>
> The debugger code is new in SVN (as I'm sure you realise)

Yes, I know. That's why I was still awake at 1am. This is *the* new
feature that I was waiting for.

It seems a plugin is required to use the debugger. I don't find it in
the pgAdmin repository. Is it available elsewhere ? or perhaps I didn't
search enough...

> and has only really been tested on VC++ in the past. It builds on developer, and my Mac, but maybe your compiler is
morepicky. 
>

I work on a Kubuntu 6.10. g++'s release is "g++ (GCC) 4.1.2 20060928
(prerelease) (Ubuntu 4.1.1-13ubuntu5)".

Without my patch, g++ quits with this error message :
../debugger/include/wsCodeWindow.h:
   At global scope:
../debugger/include/wsCodeWindow.h:208:
   error: extra qualification ‘wsCodeWindow::’ on member ‘OnClose’

> Please go ahead and commit your patch.
>

Done. Thanks :)


--
Guillaume.
<!-- http://abs.traduc.org/
      http://lfs.traduc.org/
      http://docs.postgresqlfr.org/ -->

> ------- Original Message -------
> From: Guillaume Lelarge <guillaume@lelarge.info>
> To: Dave Page <dpage@postgresql.org>
> Sent: 17/03/07, 14:03:47
> Subject: Re: [pgadmin-hackers] Bad declaration ?
>
> Dave Page a écrit :
> >> From: Guillaume Lelarge <guillaume@lelarge.info>
> >>[...]
> >> Without this patch, I'm not able to build pgAdmin. I don't know if I
> >> made something wrong or if this is a real mistake.
> >
> > The debugger code is new in SVN (as I'm sure you realise)
>
> Yes, I know. That's why I was still awake at 1am. This is *the* new
> feature that I was waiting for.

:-)

> It seems a plugin is required to use the debugger. I don't find it in
> the pgAdmin repository. Is it available elsewhere ? or perhaps I didn't
> search enough...

It's only in EnterpriseDB atm (downloads on the website). The hooks are in PostgreSQL though, and Korry is preparing
theplugin for release. 

Regards, Dave