Обсуждение: Re: SVN Commit by dpage: r5106 - in trunk/pgadmin3:

-----Original Message-----
From: "Andreas Pflug"<pgadmin@pse-consulting.de>
Sent: 01/05/06 13:29:00
To: "Dave Page"<dpage@vale-housing.co.uk>
Cc: "svn@pgadmin.org"<svn@pgadmin.org>, "pgadmin-hackers@postgresql.org"<pgadmin-hackers@postgresql.org>
Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r5106 - in trunk/pgadmin3:


> AFAICS this is basically a plain copy of the backend version? If so, I'd
> prefer to have it stored in the db directory, where we already have the
> unchanged keywords.c. All backend extracted sources should be upgradable
> from pgsql HEAD by simply copying them.

md5.c(pp) is unchanged, bar the top comment. md5.h is custom though. I have no problem moving them.

/D

-----Unmodified Original Message-----
Dave Page wrote:

>
>
> I considered this carefully and chose that method for a few reasons.

'k, after having a look what you did a I found you copied the backend's
version. I agree with your arguments.

AFAICS this is basically a plain copy of the backend version? If so, I'd
prefer to have it stored in the db directory, where we already have the
unchanged keywords.c. All backend extracted sources should be upgradable
from pgsql HEAD by simply copying them.

Regards,
Andreas

Dave Page wrote:

>
>
> md5.c(pp) is unchanged, bar the top comment. md5.h is custom though. I have no problem moving them.

Well, thinking again it appears that different from keywords.c md5.c(pp)
won't be subject to regular change. So let's leave it as it is now,
rollback my previous remarks.

Regards,
Andreas