Обсуждение: SVN Commit by dpage: r4685 - trunk/pgadmin3

Author: dpage
Date: 2005-11-06 11:13:18 +0000 (Sun, 06 Nov 2005)
New Revision: 4685

Modified:
   trunk/pgadmin3/configure.ac
Log:
Allow use of long filenames


Modified: trunk/pgadmin3/configure.ac
===================================================================
--- trunk/pgadmin3/configure.ac    2005-11-06 10:56:54 UTC (rev 4684)
+++ trunk/pgadmin3/configure.ac    2005-11-06 11:13:18 UTC (rev 4685)
@@ -6,7 +6,7 @@
 AC_CONFIG_SRCDIR([src/pgAdmin3.cpp])
 AM_CONFIG_HEADER([config.h])
 AC_CANONICAL_HOST
-AM_INIT_AUTOMAKE
+AM_INIT_AUTOMAKE([tar-ustar])
 AC_PREFIX_DEFAULT([/usr/local/pgadmin3])

 # Checks for programs.

svn@pgadmin.org wrote:
> Modified: trunk/pgadmin3/configure.ac
> ===================================================================
> --- trunk/pgadmin3/configure.ac    2005-11-06 10:56:54 UTC (rev 4684)
> +++ trunk/pgadmin3/configure.ac    2005-11-06 11:13:18 UTC (rev 4685)
> @@ -6,7 +6,7 @@
>  AC_CONFIG_SRCDIR([src/pgAdmin3.cpp])
>  AM_CONFIG_HEADER([config.h])
>  AC_CANONICAL_HOST
> -AM_INIT_AUTOMAKE
> +AM_INIT_AUTOMAKE([tar-ustar])
This broke the nightly builds. What version of automake is required
for this to work? (And, because I'm curious, what does it do? ;-) ).

greetings, Florian Pflug

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Florian G. Pflug
> Sent: 07 November 2005 00:42
> To: pgadmin-hackers
> Subject: Re: [pgadmin-hackers] SVN Commit by dpage: r4685 -
> trunk/pgadmin3
>
> svn@pgadmin.org wrote:
> > Modified: trunk/pgadmin3/configure.ac
> > ===================================================================
> > --- trunk/pgadmin3/configure.ac    2005-11-06 10:56:54 UTC
> (rev 4684)
> > +++ trunk/pgadmin3/configure.ac    2005-11-06 11:13:18 UTC
> (rev 4685)
> > @@ -6,7 +6,7 @@
> >  AC_CONFIG_SRCDIR([src/pgAdmin3.cpp])
> >  AM_CONFIG_HEADER([config.h])
> >  AC_CANONICAL_HOST
> > -AM_INIT_AUTOMAKE
> > +AM_INIT_AUTOMAKE([tar-ustar])
> This broke the nightly builds. What version of automake is required
> for this to work? (And, because I'm curious, what does it do? ;-) ).

Hmm, not on developer.pgadmin.org. It's purpose is to allow us to build
with some of the Slony docs which have extremely long filenames. I
realised when testing the first Mac build of 1.4 thart the Slony docs
were missing, however when I added them, make dist started to fail
because of the length of some of the filenames:

      `tar-ustar' selects the ustar format defined by POSIX 1003.1-1988.
      This format is believed to be old enough to be portable.  It
      fully supports empty directories.  It can store filenames with up
      to 256 characters, provided that the filename can be split at
      directory separator in two parts, first of them being at most 155
      bytes long. So, in most cases the maximum file name length will be
      shorter than 256 characters.  However you may run against broken
      tar implementations that incorrectly handle filenames longer than
      99 characters (please report them to <bug-automake@gnu.org> so we
      can document this accurately).

I don't know what version of automake is required, but
developer.pgadmin.org has 1.9.5.

Oddly, I did notice that it wasn't required on Mac, but possibly didn't
test what happened with it there. I'll try it out on Panther tonight.

Regards, Dave.

On 7/11/05 8:30 am, "Dave Page" <dpage@vale-housing.co.uk> wrote:

>
> Oddly, I did notice that it wasn't required on Mac, but possibly didn't
> test what happened with it there. I'll try it out on Panther tonight.

A quick update to autoconf 2.59 and automake 1.9.6 did the trick on Panther.

Regards, Dave

Dave Page wrote:

>>Oddly, I did notice that it wasn't required on Mac, but possibly didn't
>>test what happened with it there. I'll try it out on Panther tonight.
>
> A quick update to autoconf 2.59 and automake 1.9.6 did the trick on Panther.
Yep, a "fink selfupdate; fink update-all" did the trick for me too.
Thanks.

greetings, Florian Pflug