Обсуждение: Introduction
Hello all, I thought I should introduce myself as having just subscribed and being interested in the topic. About me: I'm working on both Linux and Win2K Systems. Our production systems have just moved from being on SQL Server 2000 to PostgreSQL. Being very used to being a DBA on SQL Server 2000, I am now adjusting my thinking to work with Postgres. Thus, when I found pgAdmin I was delighted. I have found it to be very useful and an invaluable tool. So thank you for that. I've done some vb in my time and have already downloaded the tarball for pgAdmin 2 and made a couple of changes locally to my copy just to reflect a few gui things that I am used to in SQL Server Query Analyser. I don't know if anyone else would want them but the couple of things I did were: - Allowing just a section of the SQL Query window to be executed. E.g. if you have two select statements in the same window, you can drag a selection over just one of them and hit execute and just the selected text is executed instead of all of it. - Using F5 as a keyboard shortcut for "execute". These are rather minor changes (about 10 changed lines in total) so if anyone else would like to use them I will forward them on. Anyway. Hello. A
> -----Original Message----- > From: Andy Kelk [mailto:andy@venda.com] > Sent: 06 August 2002 12:03 > To: pgadmin-hackers@postgresql.org > Subject: [pgadmin-hackers] Introduction > > > Hello all, > > I thought I should introduce myself as having just subscribed > and being interested in the topic. Hello, welcome to the list. > About me: > I'm working on both Linux and Win2K Systems. Our production > systems have just moved from being on SQL Server 2000 to > PostgreSQL. Being very used to being a DBA on SQL Server > 2000, I am now adjusting my thinking to work with Postgres. > Thus, when I found pgAdmin I was delighted. I have found it > to be very useful and an invaluable tool. So thank you for that. No problem, glad you like it. > These are rather minor changes (about 10 changed lines in > total) so if anyone else would like to use them I will > forward them on. Enhancements are always welcome as long as they fit in with the general scheme of things. Please feel free to send a patch. If you need any help with further tweaks, please feel free to email the list. Regards, Dave.
> -----Original Message----- > From: Dave Page [mailto:dpage@vale-housing.co.uk] > Sent: 06 August 2002 12:41 > To: Andy Kelk; pgadmin-hackers@postgresql.org > Subject: RE: [pgadmin-hackers] Introduction > > > Enhancements are always welcome as long as they fit in with > the general scheme of things. Please feel free to send a patch. > Right-o. I am new to doing this kind of stuff so do I just send the patched file? I only made modifications to one file: frmSQLInput.frm I have attached this file so you can see the changes. If this is not the way to go about sending modifications, give me a friendly nudge. Thanks Andy
Вложения
Andy Kelk wrote: >I only made modifications to one file: frmSQLInput.frm >I have attached this file so you can see the changes. If this is not the >way to go about sending modifications, give me a friendly nudge. > > Typically you would send a patch file, which is a file that only contains the differences between the CVS version and your version. Generating these from command line CVS requires you to actually remember a command, so I don't do it ;) On Windows I use Tortoise CVS: http://www.tortoisecvs.org/index.shtml It is, without a doubt, the coolest source control program I've ever used. It works as a Windows shell extension, and once you've installed it you barely have to understand anything about CVS. In *all* windows file browsers, files under CVS show up with a green tint, and any files you've modified show up with a red tint. To create a patch file, simply right click on a red file and from the cvs menu choose "make patch". This generates a patch file that Dave can use to apply your changes to the main CVS tree. Hopefully one day there will be a Konquerer extension that will work as well as this :P John
> -----Original Message----- > From: John McCawley [mailto:jmccawley@worleyco.com] > Sent: 06 August 2002 17:09 > To: Andy Kelk > Cc: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Introduction > > > Andy Kelk wrote: > > >I only made modifications to one file: frmSQLInput.frm > >I have attached this file so you can see the changes. If this is not > >the way to go about sending modifications, give me a friendly nudge. > > > > > > Typically you would send a patch file, which is a file that only > contains the differences between the CVS version and your version. > Generating these from command line CVS requires you to actually > remember a command, so I don't do it ;) > > On Windows I use Tortoise CVS: http://www.tortoisecvs.org/index.shtml Yes, patches are definately the nicest way (you can read the changes easily and merge with the existing source). As with the rest of the PostgreSQL project, context diffs are preferred. From the command line in a repository (i.e. *not* a tarball copy) you would do: cvs diff -c > mypatch.diff I tend to use Wincvs myself though. As it's a small mod, I'll handle it manually this time. I have had to add error handling to the Form_KeyUp sub though - if you're going to work on more patches like this (and I hope you will), it wouldn't be a bad idea to read http://www.pgadmin.org/pgadmin2.php?ContentID=8 to get an idea of how things should look (I can be overly picky sometimes :-)). Regards, Dave.
> -----Original Message----- > From: Andy Kelk [mailto:andy@venda.com] > Sent: 06 August 2002 15:01 > To: pgadmin-hackers@postgresql.org > Subject: Re: [pgadmin-hackers] Introduction > > > > -----Original Message----- > > From: Dave Page [mailto:dpage@vale-housing.co.uk] > > Sent: 06 August 2002 12:41 > > To: Andy Kelk; pgadmin-hackers@postgresql.org > > Subject: RE: [pgadmin-hackers] Introduction > > > > > > Enhancements are always welcome as long as they fit in with > > the general scheme of things. Please feel free to send a patch. > > > > Right-o. I am new to doing this kind of stuff so do I just send the > patched file? > > I only made modifications to one file: frmSQLInput.frm > > I have attached this file so you can see the changes. If this > is not the > way to go about sending modifications, give me a friendly nudge. Thanks, patch applied. Regards, Dave.