Re: Re: [COMMITTERS] pgsql: Check compulsory parameters in recovery.conf in standby_mode, per

On Mon, Apr 5, 2010 at 3:42 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On Mon, 2010-04-05 at 15:02 -0400, Alvaro Herrera wrote:
>> Simon Riggs escribió:
>> > On Mon, 2010-04-05 at 17:08 +0900, Fujii Masao wrote:
>> > > On Sat, Apr 3, 2010 at 6:50 AM, Simon Riggs <sriggs@postgresql.org> wrote:
>> > > > Log Message:
>> > > > -----------
>> > > > Check compulsory parameters in recovery.conf in standby_mode, per docs.
>> > >
>> > > On the recent discussion (*1), some people argued that specifying neither
>> > > primary_conninfo nor restore_command in the standby mode is not unreasonable,
>> > > and we reached the consensus that the setting should be allowed. So this
>> > > commit doesn't reflect the discussion. How about reverting the commit,
>> > > and restarting the discussion if you have complaint against the consensus?
>> >
>> > The attached patch changes the messages and downgrades FATAL to WARNING.
>> >
>> > Comments?
>>
>> Please note that errdetail must be a complete sentence.
>
> Better?

I haven't tested this (bad words to start out with, I know) but
assuming this message is going to print once on startup rather than
repeatedly, +1 from me.

...Robert