Re: Statistics Import and Export

Hi,

On 2025-02-20 01:39:34 -0800, Jeff Davis wrote:
> Committed with some revisions on top of v48:

This made the pg_upgrade tests considerably slower.

In an assert build without optimization (since that's what I use for normal
dev work):

1fd1bd87101^     65.03s
1fd1bd87101      86.84s


Looking at the times in the in the regress_log, I see:

good: [15:17:31.278](36.851s) ok 5 - regression tests pass
bad:  [15:15:37.857](37.437s) ok 5 - regression tests pass

good: [15:17:36.721](5.436s) ok 6 - dump before running pg_upgrade
bad:  [15:15:50.845](12.980s) ok 6 - dump before running pg_upgrade

good: [15:17:39.759](2.441s) ok 12 - run of pg_upgrade --check for new instance
bad:  [15:15:53.861](2.415s) ok 12 - run of pg_upgrade --check for new instance

good: [15:17:51.249](11.489s) ok 14 - run of pg_upgrade for new instance
bad:  [15:16:13.304](19.443s) ok 14 - run of pg_upgrade for new instance

good: [15:17:55.382](3.958s) ok 17 - dump after running pg_upgrade
bad:  [15:16:23.766](10.290s) ok 17 - dump after running pg_upgrade


Which to me rather strongly suggests pg_dump has gotten a *lot* slower with
this change.


Greetings,

Andres