Re: Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

On Thu, Apr 29, 2010 at 1:14 AM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Ok, I've finally committed the patch, using wal_level as the name of the
> GUC.

> !     if (InArchiveRecovery && XLogRequestRecoveryConnections)
> !     {
> !         if (ControlFile->wal_level < WAL_LEVEL_HOT_STANDBY)
> !             ereport(ERROR,
> !                     (errmsg("recovery connections cannot start because wal_level was not set to 'hot_standby' on
theWAL source server")));
 

I still have the complaint against the above check. Since the default value
of recovery_connections is TRUE, the users who need only archiving not
replication (i.e., wal_level is set to 'archive') are likely to often
see the failure
of the archive recovery by the above check.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center