Re: walreceiver is uninterruptible on win32
От | Fujii Masao |
---|---|
Тема | Re: walreceiver is uninterruptible on win32 |
Дата | |
Msg-id | s2k3f0b79eb1004160003ndc57ccebr729ffd9c3f42eb57@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: walreceiver is uninterruptible on win32 (Robert Haas <robertmhaas@gmail.com>) |
Ответы |
Re: walreceiver is uninterruptible on win32
Re: walreceiver is uninterruptible on win32 Re: walreceiver is uninterruptible on win32 |
Список | pgsql-hackers |
On Thu, Apr 15, 2010 at 11:26 PM, Robert Haas <robertmhaas@gmail.com> wrote: > I have to admit to finding this confusing. According to the comments: > > + /* > + * Don't emulate the PQexec()'s behavior of returning the last > + * result when there are many, since walreceiver never sends a > + * query returning multiple results. > + */ > > ...but it looks like the code actually is implementing some sort of > loop-that-returns-the-last result. Yeah, it's not a very accurate description. And I found another problem: libpqrcv_PQexec() ends as soon as an error result arrives even if its state has not been PGASYNC_IDLE yet. So I changed libpqrcv_PQexec() so that it emulates the PQexec()'s behavior except the concatenation of error messages. How about the attached patch? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Вложения
В списке pgsql-hackers по дате отправления: