Re: On login trigger: take three

Daniel Gustafsson писал 2022-03-30 16:48:
>> On 30 Mar 2022, at 13:21, Ivan Panchenko <wao@mail.ru> wrote:
>> Maybe side-effects is a bit too general? Emitting a log message, 
>> rejecting a
>> login, setting some GUCs, etc are all side-effects too.
>> Something like this:
> 
> I've reworded the docs close to what you suggested here.
> 
>> Also, please fix a typo in doc/src/sgml/ref/create_event_trigger.sgml 
>> :
> 
> Done.
> 
>> Regarding the trigger function example:
>> It does not do anything if run on a standby. To show that it can do 
>> something on a standby to, I propose to move throwing the night 
>> exception to the beginning.
> 
> Good idea, done.
> 
>> Finally, let me propose to append to the regression test the 
>> following:
> 
> Also a good idea, done.
> 
> --
> Daniel Gustafsson        https://vmware.com/

Please fix a typo in doc/src/sgml/event-trigger.sgml: "precvent"

-- 
Andrey Sokolov
Postgres Professional: http://www.postgrespro.com