On Sun, 2024-03-17 at 17:46 -0400, Tom Lane wrote:
> Jeff Davis <pgsql@j-davis.com> writes:
> > New series attached.
>
> Coverity thinks there's something wrong with builtin_validate_locale,
> and as far as I can tell it's right: the last ereport is unreachable,
> because required_encoding is never changed from its initial -1 value.
> It looks like there's a chunk of logic missing there, or else that
> the code could be simplified further.
Thank you, it was a bit of over-generalization in anticipation of
future patches.
It may be moot soon, but I committed a fix now.
Regards,
Jeff Davis