Re: pgbench tests vs Windows

On 7/24/19 3:56 AM, Fabien COELHO wrote:
>
> Hello Andrew,
>
>> Unfortunately, this isn't portable, as I've just discovered at the cost
>> of quite a bit of time. In particular, you can't assume expr is present
>> and in the path on Windows. The Windows equivalent would be something
>> like:
>>
>>    \setshell two\
>>      @set /a c = 1 + :one  && echo %c%
>
> Hmmm... Can we assume that echo is really always there on Windows? If
> so, the attached patch does something only with "echo".


Yes, it's built into the cmd processor (as is "set /a", to answer Tom's
earlier question about portability - I tested the above back to XP.)


echo is much more universal, and I can confirm that the suggested fix
works on the Windows test box I'm using.


I'll apply and backpatch that. Thanks


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services