Re: TAP tests vs log_error verbosity=verbose

On 2022-07-31 Su 12:14, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP
>> tests to handle log_error_verbosity=verbose, and there's a third case
>> needing adjustment in the new auto_explain tests (7c34555f8c). I'm
>> wondering if it would be better to set log_error_verbosity to default
>> for TAP tests, no matter what's in TEMP_CONFIG.  An individual TAP test
>> could still set log_error_verbosity=verbose explicitly if it wanted it.
>> If not I'm going to change one of my buildfarm animals to use
>> log_error_verbosity=verbose so we catch things like this earlier.
> I think it's good to be able to enable log_error_verbosity=verbose
> in case you need to track down some kind of problem.  So I'd vote
> for your second approach.
>
> 7c34555f8c is mine, so I'll go fix that.
>
>             



Thanks. prion should now catch future instances.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com