[HACKERS] warning in twophase.c
От | Amit Langote |
---|---|
Тема | [HACKERS] warning in twophase.c |
Дата | |
Msg-id | f20ac2ed-65a9-6511-e100-8fa369184603@lab.ntt.co.jp обсуждение исходный текст |
Ответы |
Re: [HACKERS] warning in twophase.c
|
Список | pgsql-hackers |
Been seeing this warning recently: twophase.c: In function ‘RecoverPreparedTransactions’: twophase.c:1916:9: warning: variable ‘overwriteOK’ set but not used [-Wunused-but-set-variable] bool overwriteOK = false; ^~~~~~~~~~~ As the message says, the value of overwriteOK is not used anywhere in RecoverPreparedTransactions: bool overwriteOK = false; /* * It's possible that SubTransSetParent has been set before, if * the prepared transaction generatedxid assignment records. Test * here must match one used in AssignTransactionId(). */ if (InHotStandby&& (hdr->nsubxacts >= PGPROC_MAX_CACHED_SUBXIDS || XLogLogicalInfoActive())) overwriteOK = true; Couldn't we get rid of it? Thanks, Amit
В списке pgsql-hackers по дате отправления: