Re: ICU for global collation

On 16.09.22 09:31, Marina Polyakova wrote:
> IMO it is hardly understantable from the program output either - it 
> looks like I manually chose the encoding UTF8. Maybe first inform about 
> selected encoding?..

Yes, I included something like that in the patch just committed.

> diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
> index 
> 6aeec8d426c52414b827686781c245291f27ed1f..348bbbeba0f5bc7ff601912bf883510d580b814c 100644
> --- a/src/bin/initdb/initdb.c
> +++ b/src/bin/initdb/initdb.c
> @@ -2310,7 +2310,11 @@ setup_locale_encoding(void)
>       }
> 
>       if (!encoding && locale_provider == COLLPROVIDER_ICU)
> +    {
>           encodingid = PG_UTF8;
> +        printf(_("The default database encoding has been set to \"%s\" 
> for a better experience with the ICU provider.\n"),
> +               pg_encoding_to_char(encodingid));
> +    }
>       else if (!encoding)
>       {
>           int            ctype_enc;