Re: [HACKERS] PATCH: Make pg_stop_backup() archive wait optional

On 3/21/17 2:34 PM, Fujii Masao wrote:
> On Tue, Mar 21, 2017 at 11:03 AM, Tsunakawa, Takayuki
> <tsunakawa.takay@jp.fujitsu.com> wrote:
>> From: David Steele [mailto:david@pgmasters.net]
>>> Well, that's embarrassing.  When I recreated the function to add defaults
>>> I messed up the AS clause and did not pay attention to the results of the
>>> regression tests, apparently.
>>>
>>> Attached is a new version rebased on 88e66d1.  Catalog version bump has
>>> also been omitted.
>>
>> I was late to reply because yesterday was a national holiday in Japan.  I marked this as ready for committer.  The
patchapplied cleanly and worked as expected.
 
>
> The patch basically looks good to me, but one comment is;
> backup.sgml (at least the description for "Making a non-exclusive
> low level backup) seems to need to be updated.

Agreed.  Added in the attached patch and rebased on 8027556.

Thanks!
-- 
-David
david@pgmasters.net

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers