Re: speed up a logical replica setup

On Mon, Jan 22, 2024 at 2:38 PM Hayato Kuroda (Fujitsu)

<kuroda.hayato@fujitsu.com> wrote:

> >

> > > Yet other options could be

> > > pg_buildsubscriber, pg_makesubscriber as 'build' or 'make' in the name

> > > sounds like we are doing some work to create the subscriber which I

> > > think is the case here.

> >

> > I see your point here.  pg_createsubscriber is not like createuser in

> > that it just runs an SQL command.  It does something different than

> > CREATE SUBSCRIBER.

Right.

  So a different verb would make that clearer.  Maybe

> > something from here: https://www.thesaurus.com/browse/convert

>

> I read the link and found a good verb "switch". So, how about using "pg_switchsubscriber"?

>

I also initially thought on these lines and came up with a name like

pg_convertsubscriber but didn't feel strongly about it as that would

have sounded meaningful if we use a name like

pg_convertstandbytosubscriber. Now, that has become too long. Having

said that, I am not opposed to it having a name on those lines. BTW,

another option that occurred to me today is pg_preparesubscriber. We

internally create slots and then wait for wal, etc. which makes me

sound like adding 'prepare' in the name can also explain the purpose.