Re: Compiling HEAD with -Werror int 64-bit mode

Поиск
Список
Период
Сортировка
От Marko Kreen
Тема Re: Compiling HEAD with -Werror int 64-bit mode
Дата
Msg-id e51f66da0912151340y5b619431x7822cc2359d9eecd@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Compiling HEAD with -Werror int 64-bit mode  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On 12/15/09, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>  > I have also tried in the past to pass -Werror through configure, but
>  > that caused too many problems.
>
>  Is it your opinion that we shouldn't bother fixing this particular
>  test?  I was on the fence about it myself.  I don't want to promise
>  that configuring with -Werror will work, now or in the future; but
>  making this one test safe doesn't seem too onerous.

It's better to fail with certainty, than toggle randomly some
features on/off...

Unless autoconf guys promise that their macros are meant to work with
-Werror, it seems safer to fail.  Plus there are our own macros.

How about explicit switch to turn -Werror on, safely?

-- 
marko


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Marko Kreen
Дата:
Сообщение: Re: Patch: Remove gcc dependency in definition of inline functions
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: Hot Standby and prepared transactions