Re: [HACKERS] Logical replication existing data copy

On 2017-01-18 20:45, Petr Jelinek wrote:
> 
> AFAICS you should always get error from that test after you enable the

Ah tes, you were right, of course;  I had assumed the earlier mentioned
CREATE SUBSCRIPTION ... [ WITH (COPY DATA | NOCOPY DATA) ]
but that syntax wasn't implemented, I now understand.

Taking that into account, my older tests work OK again (using the 
7-patches below).


Other small issue: using this patch-set:

> 0001-Add-PUBLICATION-catalogs-and-DDL-v18.patch
> 0002-Add-SUBSCRIPTION-catalog-and-DDL-v18.patch
> 0003-Define-logical-replication-protocol-and-output-plugi-v18.patch
> 0004-Add-logical-replication-workers-v18fixed.patch
> 0005-Add-separate-synchronous-commit-control-for-logical--v18.patch
> 0001-Logical-replication-support-for-initial-data-copy-v2.patch
> 0006-Add-RENAME-support-for-PUBLICATIONs-and-SUBSCRIPTION.patch

( This is now the patch-set to test, is that correct? )

make check complains:

*** 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.logical_replication/src/test/regress/expected/subscription.out    2017-01-19 
09:26:41.354703032 +0100
--- 
/home/aardvark/pg_stuff/pg_sandbox/pgsql.logical_replication/src/test/regress/results/subscription.out    2017-01-19 
09:29:56.104685043 +0100
***************
*** 53,62 ****  COMMIT;  ALTER SUBSCRIPTION testsub RENAME TO testsub_foo;  \dRs
!                          List of subscriptions
!     Name     |           Owner           | Enabled |    Publication
! 
-------------+---------------------------+---------+--------------------
!  testsub_foo | regress_subscription_user | f       | 
{testpub,testpub1}  (1 row)
  DROP SUBSCRIPTION testsub_foo NODROP SLOT;
--- 53,62 ----  COMMIT;  ALTER SUBSCRIPTION testsub RENAME TO testsub_foo;  \dRs
!                       List of subscriptions
!     Name     |           Owner           | Enabled | Publication
! -------------+---------------------------+---------+-------------
!  testsub_foo | regress_subscription_user | f       | {testpub}  (1 row)
  DROP SUBSCRIPTION testsub_foo NODROP SLOT;

======================================================================


Thanks,


Erik Rijkers