Re: ICU for global collation

On 21.01.22 14:51, Julien Rouhaud wrote:
>>  From 1c46bf3138ad42074971aa3130142236de7e63f7 Mon Sep 17 00:00:00 2001
>> From: Peter Eisentraut <peter@eisentraut.org>
>> Date: Fri, 21 Jan 2022 10:01:25 +0100
>> Subject: [PATCH] Change collate and ctype fields to type text
> 
> +            collversionstr = TextDatumGetCString(datum);
> +
>               actual_versionstr = get_collation_actual_version(collform->collprovider, collcollate);
>               if (!actual_versionstr)
>               {
> @@ -1606,7 +1616,6 @@ pg_newlocale_from_collation(Oid collid)
>                           (errmsg("collation \"%s\" has no actual version, but a version was specified",
>                                   NameStr(collform->collname))));
>               }
> -            collversionstr = TextDatumGetCString(collversion);
> 
> 
> Is that change intended?  There isn't any usage of the collversionstr before
> the possible error when actual_versionstr is missing.

I wanted to move it closer to the SysCacheGetAttr() where the "datum" 
value is obtained.  It seemed weird to get the datum, then do other 
things, then decode the datum.