Re: list of extended statistics on psql

On 1/20/21 7:41 AM, Tatsuro Yamada wrote:
> Hi Tomas,
> 
> On 2021/01/20 11:35, Tatsuro Yamada wrote:
>>> Apologies for all the extra work - I haven't realized this flaw when 
>>> pushing for showing more stuff :-(
>>
>> Don't worry about it. We didn't notice the problem even when viewed by 
>> multiple
>> people on -hackers. Let's keep moving forward. :-D
>>
>> I'll send a patch including a regression test on the next patch.
> 
> 
> I created patches and my test results on PG10, 11, 12, and 14 are fine.
> 
>    0001:
>      - Fix query to use pg_statistic_ext only
>      - Replace statuses "required" and "built" with "defined"
>      - Remove the size columns
>      - Fix document
>      - Add schema name as a filter condition on the query
> 
>    0002:
>      - Fix all results of \dX
>      - Add new testcase by non-superuser
> 
> Please find attached files. :-D

Thanks, I've pushed this. I had to tweak the regression tests a bit, for 
two reasons:

1) to change user in regression tests, don't use \connect, but SET ROLE 
and RESET ROLE

2) roles in regression tests should use names with regress_ prefix



regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company