Re: Windowing Function Patch Review -> Standard Conformance

2008/11/25 Hitoshi Harada <umi.tanuki@gmail.com>:
> 2008/11/25 Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>:
>> Here's an updated patch, where the rows are fetched on-demand.
>
> Good! And I like the fetching args by number better. Let me take more
> time to look in detail...

I read more, and your spooling approach seems flexible for both now
and the furture. Looking at only current release, the frame with ORDER
BY is done by detecting peers in WinFrameGetArg() and add row number
of peers to winobj->currentpos. Actually if we have capability to
spool all rows we need on demand, the frame would be only a boundary
problem.

It seems to me that eval_windowaggregate() also should use frame APIs.
Only things we have to care is the shrinking frame, which is not
supported in this release. So I'd suggest winobj->aggregatedupto to be
removed. Is there objection?

Regards,


-- 
Hitoshi Harada