Re: Status of DISTINCT-by-hashing work

2008/8/6 Tom Lane <tgl@sss.pgh.pa.us>:
> "Hitoshi Harada" <umi.tanuki@gmail.com> writes:
>> In my patch nodeWindow.c, some functions reach for its parent state
>> node to get info of sort keys by using fcinfo->context. This works but
>> is completely ugly.
>
> Isn't that the same thing nodeAgg does: pass its AggState to aggregate
> functions?  I don't see anything ugly about it --- at least, any
> alternative you care to name is likely to be far worse.

Correct. I learned that method from nodeAgg. What I meant was that
window functions reach for plan node and its sort keys through
winstate->ss.ps. The mechanism is not ugly but some macros or exposed
API seem more comfortable, especially if thinking about formulating
window functions as user-defined functions.

Regards,


-- 
Hitoshi Harada