Re: moving basebackup code to its own directory

On 8/9/22 14:40, Justin Pryzby wrote:
> On Tue, Aug 09, 2022 at 01:32:49PM -0400, Robert Haas wrote:
>> On Tue, Aug 9, 2022 at 12:43 PM Magnus Hagander <magnus@hagander.net> wrote:
>>>>> So maybe src/backend/backup? Or is that too grandiose for the amount
>>>>> of stuff we have here?
>>>>
>>>> +1 for src/backend/backup. I'd also be happy to see the start/stop code
>>>> move here at some point.
>>>
>>> Yeah, sounds reasonable. There's never an optimal source code layout, but I agree this one is better than putting
itunder replication.
 
>>
>> OK, here's a patch.
> 
> It looks like this updates the header comments in the .h files but not the .c
> files.
> 
> Personally, I find these to be silly boilerplate ..

Good catch. I did not notice that just looking at the diff.

Definitely agree that repeating the filename in the top comment is 
mostly useless, but that seems like a separate conversation.

-David