Re: Install github app to automatically close PRs on github mirror
От | Justin Clift |
---|---|
Тема | Re: Install github app to automatically close PRs on github mirror |
Дата | |
Msg-id | da7caed8b341872c532f20c64a4c5d97@postgresql.org обсуждение исходный текст |
Ответ на | Re: Install github app to automatically close PRs on github mirror (Andres Freund <andres@anarazel.de>) |
Список | pgsql-www |
On 2019-04-19 16:28, Andres Freund wrote: > Hi, > > On 2019-04-19 14:13:12 +1000, Justin Clift wrote: >> On 2019-04-19 02:27, Andres Freund wrote: >> <snip> >> > I installed the app into both repositories - because I wasn't sure >> > whether it needed the file-path access permission to the >> > .github/lockdown.yml even if the .github repo is public. And I was too >> > lazy to experiment ;) >> > >> > But it seems to work even without that as long as .github is >> > public. I've merged your PR now :P >> >> Cool. :) >> >> Having the "auto-close" message being friendly can make an important >> difference in keeping the potential contributor around. > > I totally aggree - but just to be clear, that was my private, unused > fork of the postgres repo. I just wanted to test the github app and > wrote the minimal testcase I could think of ;). If it were the real > postgres repo I'd spend a bit more time on the message than I had... Ahhh dammit. I didn't read closely enough and just assumed you'd figured some way of getting it working with the real PG repo. Oops. ;) + Justin
В списке pgsql-www по дате отправления: