Re: Cleaning up and speeding up string functions

Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> On 2019-Jul-22, Dagfinn Ilmari Mannsåker wrote:
>
>> ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:
>> 
>> > I noticed a lot of these are appending one StringInfo onto another;
>> > would it make sense to introduce a helper funciton
>> > appendStringInfoStringInfo(StringInfo str, StringInfo str2) to avoid the
>> > `str.data, str2.len` repetition?
>> 
>> A bit of grepping only turned up 18 uses, but I was bored and whipped up
>> the attached anyway, in case we decide it's worth it.
>
> David had already submitted the same thing upthread, and it was rejected
> on the grounds that it increases the code space.

Oops, sorry, I missed that. Never mind then.

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law