Re: REINDEX CONCURRENTLY 2.0

Michael Paquier <michael@paquier.xyz> writes:

> So...  I am coming up with the patch attached.  I have introduced some
> tests using a trick with CIC to have an invalid index to work on.

I don't have any comments on the code (but the test looks sensible, it's
the same trick I used to discover the issue in the first place).

However, the doc patch lost the trailing paren:

>      The recommended recovery
>      method in such cases is to drop the index and try again to perform
> -    <command>CREATE INDEX CONCURRENTLY</command>.  (Another possibility is to rebuild
> -    the index with <command>REINDEX</command>.  However, since <command>REINDEX</command>
> -    does not support concurrent builds, this option is unlikely to seem
> -    attractive.)
> +    <command>CREATE INDEX CONCURRENTLY</command>.  (Another possibility is
> +    to rebuild the index with <command>REINDEX INDEX CONCURRENTLY</command>.
>     </para>


- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl