Re: improve performance of pg_dump with many sequences
От | Euler Taveira |
---|---|
Тема | Re: improve performance of pg_dump with many sequences |
Дата | |
Msg-id | d7f5942e-00ba-4d90-9bac-f0b2b7092dc4@app.fastmail.com обсуждение исходный текст |
Ответ на | Re: improve performance of pg_dump with many sequences (Nathan Bossart <nathandbossart@gmail.com>) |
Ответы |
Re: improve performance of pg_dump with many sequences
|
Список | pgsql-hackers |
On Wed, Jul 10, 2024, at 7:05 PM, Nathan Bossart wrote:
I'm not following why that would be a better approach. strncpy() will adda NUL to the end of the string unless it doesn't fit in the buffer, inwhich case we'll add our own via "seqtype[sizeof(seqtype) - 1] = '\0'".Furthermore, the compiler can determine the position where the NUL shouldbe placed, whereas placing it at the end of the copied string requires aruntime strlen().
Nevermind, you are copying the whole buffer (n = sizeof(seqtype)).
Unfortunately, I think we have to keep this workaround since older minorreleases of PostgreSQL don't have the fix.
Hmm. Right.
What pg_dump command did you test here? Did you dump the sequence data, orwas this --schema-only?
time pg_dump -f - -s -d postgres
В списке pgsql-hackers по дате отправления: