Re: PGCOLOR? (Re: pgsql: Unified logging system for command-lineprograms)

On 2019-04-09 11:22, Christoph Berg wrote:
> Can we rename PG_COLOR to PGCOLOR? This is the only PG* environment
> variable prefixed with the extra underscore, and remembering that will
> be confusing. (Like pgbench should really be named pg_bench for
> consistency.) Even if it's not a libpq variable, but that's an
> implementation detail that users shouldn't have to worry about.

I'm okay with changing it.  As you indicate, I chose the name so that it
doesn't look like a libpq variable.  There are some other PG_ variables
throughout the code, but those appear to be mostly for internal use.
Also, there is GCC_COLORS, LS_COLORS, etc.  But perhaps this wisdom will
be lost on users who just read the man page and get confused. ;-)

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services