Re: turn fastgetattr and heap_getattr to inline functions

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: turn fastgetattr and heap_getattr to inline functions
Дата
Msg-id ce70075f-a7fa-fadb-141f-4eb7bd229f91@enterprisedb.com
обсуждение исходный текст
Ответ на Re: turn fastgetattr and heap_getattr to inline functions  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: turn fastgetattr and heap_getattr to inline functions  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Список pgsql-hackers
On 24.03.22 13:09, Michael Paquier wrote:
> Hmm.  I think that you'd better add a return at the end of each
> function?  Some compilers are dumb in detecting that all the code
> paths return (aka recent d0083c1) and could generate warnings, even if
> things are coded to return all the time, like in your patch.

That is a different case.  We know that not all compilers understand 
when elog/ereport return.  But no compiler is stupid enough not to 
understand that

foo()
{
     if (something)
         return this;
     else
         return that;
}

always reaches a return.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Simon Riggs
Дата:
Сообщение: Re: Documenting when to retry on serialization failure
Следующее
От: Peter Eisentraut
Дата:
Сообщение: Re: turn fastgetattr and heap_getattr to inline functions