Re: [HACKERS] float8 regression failure (HEAD, cygwin)

On 01/08/06, Andrew Dunstan <andrew@dunslane.net> wrote:
> Adrian Maier wrote:
> > On 20/07/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> > Apparently the regression test is comparing the results/float8.out
> > with expected/float8-small-is-zero.out  because of the following line
> > in
> > src/test/regress/resultmap :
> >   float8/i.86-pc-cygwin=float8-small-is-zero
> >
> > I've changed that line to :
> >    float8/i.86-pc-cygwin=float8
> > and the regression test ended successfully :   "All 100 tests passed."
> >
> > I don't know why there are several expected results for the float8 test,
> > depending on the platform. Is the modification ok?
> >
> > I've attached the patch,  and  cc'ed   to pgsql-patches.
>
> The problem with this is that we have another Cygwin member on buildfarm
> which passes the tests happily, and will thus presumably fail if we make
> this patch. You are running Cygwin 1.5.21 and the other buildfarm member
> is running 1.5.19, so that is possibly the difference.

This is indeed a problem.   It would be difficult or even impossible to
use different expected results for different versions of cygwin.

> Maybe we need to abandon trying to map float8 results exactly in the
> resultmap file, and just let pg_regress pick the best fit as we do with
> some other tests.

Oh, is it possible to do that?  That sounds great.  Which other tests
work like that?


Cheers,
Adrian Maier