Re: Refactoring postgres_fdw code to rollback remote transaction

On 2021/09/17 15:33, Bharath Rupireddy wrote:
> On Fri, Sep 17, 2021 at 8:28 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2021/09/17 11:40, Zhihong Yu wrote:
>>> +           goto fail;          /* Trouble clearing prepared statements */
>>>
>>> The label fail can be removed. Under the above condition,  entry->changing_xact_state is still true. You can
directlyreturn.
 
>>
>> Thanks for the review! Yes, you're right. Attached the updated version of the patch.
> 
> +1 for the code refactoring (1 file changed, 75 insertions(+), 102
> deletions(-)).
> 
> The v2 patch looks good to me as is.

Thanks for the review! Barring any objection, I will commit the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION