Re: [PATCH] Log details for client certificate failures

Поиск
Список
Период
Сортировка
От Jacob Champion
Тема Re: [PATCH] Log details for client certificate failures
Дата
Msg-id ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com
обсуждение исходный текст
Ответ на Re: [PATCH] Log details for client certificate failures  (Andres Freund <andres@anarazel.de>)
Ответы Re: [PATCH] Log details for client certificate failures  (Andres Freund <andres@anarazel.de>)
Список pgsql-hackers
On 7/15/22 12:11, Andres Freund wrote:
> This might have been discussed somewhere, but I'm worried about emitting
> unescaped data from pre-auth clients. What guarantees that subject / issuer
> name only contain printable ascii-chars? Printing terminal control chars or
> such would not be great, nor would splitting a string at a multi-boundary.

Hm. The last time I asked about that, Magnus pointed out that we reflect
port->user_name as-is [1], so I kind of stopped worrying about it. Is
this more dangerous than that? (And do we want to fix it now,
regardless?) What guarantees are we supposed to be making for log encoding?

Thanks,
--Jacob

[1]
https://www.postgresql.org/message-id/CABUevExVHryTasKmtJW5RtU-dBesYj4bV7ggpeVMfiPCHCvLNA%40mail.gmail.com



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: optimize lookups in snapshot [sub]xip arrays
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [PATCH] Log details for client certificate failures