Re: pg_dump doesn't dump new objects created in schemas from extensions

El 17/06/16 a las 20:31, Michael Paquier escribió:
> On Sat, Jun 18, 2016 at 2:21 AM, Martín Marqués <martin@2ndquadrant.com> wrote:
>>
>> If there are no complains, I could apply similar changes on other
>> objects for a more complete patch.
>>
>> Thoughts, objections?
>
> Tests, and refactoring.
>
> As this is going to be heavily duplicated, you may want to use a
> different routine for this check.

Yes, that was my initial thought.

> Integrating some tests with a dummy
> extension that creates a schema would also be a good idea as this is
> likely going to modify many code paths. So I think that we should have
> something stored in src/test/modules that gets installed when running
> make check in src/bin/pg_dump, and then one of the TAP scripts in t/
> creates a bunch of objects on the schema created by the extension.

AFAICS there's a test_pg_dump module in src/test/modules which is there
to test pg_dump with extensions. I think that might be the best place to
have these tests.

Regards,

--
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services