Re: [RFC] Removing "magic" oids

On 11/21/18 7:14 PM, Andres Freund wrote:
>   Could you check whether you
> still encounter the issue after applying the attached fix?
>


This has largely fixed the problem, so I think this should be applied. 
With some adjustments to the tests to remove problematic cases (e.g. 
postgres_fdw's ft_pg_type) the tests pass. The exception is HEAD->HEAD. 
The change is that the LOs are not dumped in the same order pre and post 
upgrade. I can change the tests to allow for a greater fuzz factor - 
generally when the source and target are the same we don't allow any 
fuzz. Or if we care we could do a better job of dumping LOs in a 
consistent order.


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services