Re: pg_upgrade failing for 200+ million Large Objects

On 3/23/21 2:35 PM, Tom Lane wrote:
> Jan Wieck <jan@wi3ck.info> writes:
>> So the question remains, how do we name this?
> 
>>      --pg-dump-options "<string>"
>>      --pg-restore-options "<string>"
> 
> If you're passing multiple options, that is
> 
>     --pg-dump-options "--foo=x --bar=y"
> 
> it seems just horribly fragile.  Lose the double quotes and suddenly
> --bar is a separate option to pg_upgrade itself, not part of the argument
> for the previous option.  That's pretty easy to do when passing things
> through shell scripts, too.  So it'd likely be safer to write
> 
>     --pg-dump-option=--foo=x --pg-dump-option=--bar=y
> 
> which requires pg_upgrade to allow aggregating multiple options,
> but you'd probably want it to act that way anyway.

... which would be all really easy if pg_upgrade wouldn't be assembling 
a shell script string to pass into parallel_exec_prog() by itself.

But I will see what I can do ...


Regards, Jan


-- 
Jan Wieck
Principle Database Engineer
Amazon Web Services