Re: Collation versioning

On 2020-03-17 18:43, Julien Rouhaud wrote:
> On Tue, Mar 17, 2020 at 05:31:47PM +0100, Christoph Berg wrote:
>> Re: Peter Eisentraut 2020-03-17<fd8d4475-85ad-506f-2dda-f4d6e66785bc@2ndquadrant.com>
>>> Did we discuss the regcollation type?  In the current patch set, it's only
>>> used in two places in a new regression test, where it can easily be replaced
>>> by a join.  Do we need it?
> 
> I originally wrote it for a previous version of the patchset, to shorten the
> pg_dump query, but that went out when I replaced the DDL command with native
> functions instead.  It didn't seem to hurt to keep it, so I relied on it in the
> regression tests.

OK, I have committed the regcollation patch, and some surrounding 
cleanup of the reg* types documentation.

Note that your patch updated the pg_upgrade documentation to say that 
tables with regcollation columns cannot be upgraded but didn't actually 
patch the pg_upgrade code to make that happen.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services