Re: 010_pg_basebackup.pl vs multiple filesystems

On 2024-07-08 Mo 4:45 PM, Robert Haas wrote:
> On Sun, Jul 7, 2024 at 3:02 AM Andres Freund <andres@anarazel.de> wrote:
>> While working on [1] I encountered the issue that, on github-actions,
>> 010_pg_basebackup.pl fails on windows.
>>
>> The reason for that is that github actions uses two drives, with TMP/TEMP
>> located on c:, the tested code on d:.  This causes the following code to fail:
>>
>>    # Create a temporary directory in the system location.
>>    my $sys_tempdir = PostgreSQL::Test::Utils::tempdir_short;
> Whatever we end up doing about this, it would be a good idea to check
> the other places that use tempdir_short and see if they also need
> adjustment.


I don't think it's a problem. There are lots of systems that have 
tempdir on a different device. That's why we previously saw lots of 
errors from this code, resulting in the present incomplete workaround. 
The fact that we haven't seen such errors from other tests means we 
should be ok.


cheers


andrew

-- 

Andrew Dunstan
EDB: https://www.enterprisedb.com