Re: Amcheck verification of GiST and GIN

On 6/17/25 16:19, Thom Brown wrote:
> On Mon, 16 Jun 2025 at 21:00, Tomas Vondra <tomas@vondra.me> wrote:
>>
>> On 6/16/25 21:09, Arseniy Mukhin wrote:
>>> On Mon, Jun 16, 2025 at 6:58 PM Tomas Vondra <tomas@vondra.me> wrote:
>>>>
>>>> Thanks.
>>>>
>>>> I went through the patches, polished the commit messages and did some
>>>> minor tweaks in patch 0002 (to make the variable names a bit more
>>>> consistent, and reduce the scope a little bit). I left it as a separate
>>>> patch to make the changes clearer, but it should be merged into 0002.
>>>>
>>>> Please read through the commit messages, and let me know if I got some
>>>> of the details wrong (or not clear enough). Otherwise I plan to start
>>>> pushing this soon (~tomorrow).
>>>
>>> LGTM.
>>> Noticed a few typos in messages:
>>> in v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch
>>>    - parent key is creator
>>>    - as the core incorrectly expected
>>> and 'Arseniy Mikhin' in some patches.
>>>
>>
>> Thanks for noticing those typos, especially the one in the name.
> 
> Do today's commits clear this from the PostgreSQL 18 Open Items list?
> 

That's the intent, yes. There's one remaining commit.


-- 
Tomas Vondra