Re: Tips on committing

On 06/29/2018 02:19 PM, Michael Paquier wrote:
> On Fri, Jun 29, 2018 at 02:04:07PM +0200, Peter Eisentraut wrote:
>> On 6/28/18 17:14, Alvaro Herrera wrote:
>>>>       2  Reported-by:
>>>>       5  Author:
>>>>       6  Reviewed-by:
>>>>       7  Tested-by:
>>> Should these include email addresses?
>>
>> One reason I include emails is that sometimes the names are spelled
>> in inconsistent ways or don't include ASCII characters at all. An
>> email address is always clear.
> 
> I don't know if emails are actually a good idea to include. Those
> tend to change when folks change company, and a lot of people here
> use company-based email addresses to discuss and work on patches.

Why would that be a problem? It's not a stable identifier, but it also 
does not change very often. Also, those who submit patches from company 
addresses do it because the patch comes from that company, and I think 
it's a good idea to keep that information.

While it might not be the primary goal, I assume people will try to 
process those fields by various scripts (generating stats, charts, ...). 
E-mails seem to be easier to correlate than just names.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services