On 7/13/23 17:38, Dean Rasheed wrote:
> On Tue, 11 Jul 2023 at 21:43, Gurjeet Singh <gurjeet@singh.im> wrote:
>>
>>>> I think the name of function pg_merge_when_clause() can be improved.
>>>> How about pg_merge_when_clause_ordinal().
>>>
>>> That's a bit of a mouthful, but I don't have a better idea right now.
>>> I've left the names alone for now, in case something better occurs to
>>> anyone.
>>
>> +1. How do we make sure we don't forget that it needs to be named
>> better. Perhaps a TODO item within the patch will help.
>>
>
> Thinking about that some more, I think the word "number" is more
> familiar to most people than "ordinal". There's the row_number()
> function, for example.
There is also the WITH ORDINALITY and FOR ORDINALITY examples.
So perhaps pg_merge_when_clause_number() would
> be a better name. It's still quite long, but it's the best I can think
> of.
How about pg_merge_match_number() or pg_merge_ordinality()?
--
Vik Fearing