Re: Performing partition pruning using row value

On 21.07.2020 11:24, kato-sho@fujitsu.com wrote:
>> So, after looking at these functions and modifying this patch, I would like to add this patch to the next
> I updated this patch and registered for the next CF .
>
> https://commitfest.postgresql.org/29/2654/
>
> regards,
> sho kato

Thank you for working on this improvement. I took a look at the code.

1) This piece of code is unneeded:

             switch (get_op_opfamily_strategy(opno, partopfamily))
             {
                 case BTLessStrategyNumber:
                 case BTLessEqualStrategyNumber:
                 case BTGreaterEqualStrategyNumber:
                 case BTGreaterStrategyNumber:

See the comment for RowCompareExpr, which states that "A RowCompareExpr 
node is only generated for the < <= > >= cases".

2) It's worth to add a regression test for this feature.

Other than that, the patch looks good to me.

-- 
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company