On 1/8/22 04:25, Michael Paquier wrote:
> On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote:
>> 2) crake fails perl-check
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26
>>
>> All the failures are the same, because of the shape of the subroutine
>> definitions:
>> Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
>> Subroutine prototypes used at line 13, column 1. See page 194 of
>> PBP. ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)
> This issue is just caused by the way the subroutines are defined,
> meaning that the attached cools down pgperlcritic. Any objections if
> I apply that to cool down crake? Jeff, if you wish to do so, please
> feel free of course.
Please do this. Subroutine prototypes should only be used in very
restricted circumstances in Perl. I can't recall when I've ever needed them.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com