Re: [HACKERS] Logical Replication and Character encoding

On 03/03/17 20:37, Peter Eisentraut wrote:
> On 2/27/17 00:23, Kyotaro HORIGUCHI wrote:
>> Yeah, the patch sends converted string with the length of the
>> orignal length. Usually encoding conversion changes the length of
>> a string. I doubt that the reverse case was working correctly.
> 
> I think we shouldn't send the length value at all.  This might have been
> a leftover from an earlier version of the patch.
> 
> See attached patch that removes the length value.
> 

Well the length is necessary to be able to add binary format support in
future so it's definitely not an omission.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services