Re: Fix vcregress plpython3 warning

On 1/7/22 08:56, Juan José Santamaría Flecha wrote:
>
> On Fri, Jan 7, 2022 at 2:30 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
>     Yeah, this code is not a model of clarity though. I had to think
>     through
>     it and I write quite a bit of perl. I would probably write it
>     something
>     like this:
>
>
>     s/EXTENSION (.*?)plpython2?u/EXTENSION $1plpython3u/g ;
>
> Yeah, I had to do some testing to figure it out. Based on
> what regress-python3-mangle.mk <http://regress-python3-mangle.mk>
> does, I think it tries to ignore cases such as:
>
> DROP EXTENSION IF EXISTS plpython2u CASCADE;
>
> Which that expression would match. Maybe use a couple of lines as in
> the make file?
>
> s/EXTENSION plpython2?u/EXTENSION plpython3u/g
> s/EXTENSION ([^ ]*)_plpython2?u/EXTENSION \$1_plpython3u/g
>
>

In that case, just this should work:


s/EXTENSION (\S*?)plpython2?u/EXTENSION $1plpython3u/g ;


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com