Re: [HACKERS] Logical Replication WIP

On 2017-01-15 23:20, Petr Jelinek wrote:

> 0001-Add-PUBLICATION-catalogs-and-DDL-v18.patch
> 0002-Add-SUBSCRIPTION-catalog-and-DDL-v18.patch
> 0003-Define-logical-replication-protocol-and-output-plugi-v18.patch
> 0004-Add-logical-replication-workers-v18.patch
> 0005-Add-separate-synchronous-commit-control-for-logical--v18.patch

patches apply OK (to master), but I get this compile error:

execReplication.c: In function ‘ExecSimpleRelationInsert’:
execReplication.c:392:41: warning: passing argument 3 of 
‘ExecConstraints’ from incompatible pointer type 
[-Wincompatible-pointer-types]    ExecConstraints(resultRelInfo, slot, estate);
^~~~~~
In file included from execReplication.c:21:0:
../../../src/include/executor/executor.h:197:13: note: expected 
‘TupleTableSlot * {aka struct TupleTableSlot *}’ but argument is of type 
‘EState * {aka struct EState *}’ extern void ExecConstraints(ResultRelInfo *resultRelInfo,             ^~~~~~~~~~~~~~~
execReplication.c:392:4: error: too few arguments to function 
‘ExecConstraints’    ExecConstraints(resultRelInfo, slot, estate);    ^~~~~~~~~~~~~~~
In file included from execReplication.c:21:0:
../../../src/include/executor/executor.h:197:13: note: declared here extern void ExecConstraints(ResultRelInfo
*resultRelInfo,            ^~~~~~~~~~~~~~~
 
execReplication.c: In function ‘ExecSimpleRelationUpdate’:
execReplication.c:451:41: warning: passing argument 3 of 
‘ExecConstraints’ from incompatible pointer type 
[-Wincompatible-pointer-types]    ExecConstraints(resultRelInfo, slot, estate);
^~~~~~
In file included from execReplication.c:21:0:
../../../src/include/executor/executor.h:197:13: note: expected 
‘TupleTableSlot * {aka struct TupleTableSlot *}’ but argument is of type 
‘EState * {aka struct EState *}’ extern void ExecConstraints(ResultRelInfo *resultRelInfo,             ^~~~~~~~~~~~~~~
execReplication.c:451:4: error: too few arguments to function 
‘ExecConstraints’    ExecConstraints(resultRelInfo, slot, estate);    ^~~~~~~~~~~~~~~
In file included from execReplication.c:21:0:
../../../src/include/executor/executor.h:197:13: note: declared here extern void ExecConstraints(ResultRelInfo
*resultRelInfo,            ^~~~~~~~~~~~~~~
 
make[3]: *** [execReplication.o] Error 1
make[2]: *** [executor-recursive] Error 2
make[1]: *** [install-backend-recurse] Error 2
make: *** [install-src-recurse] Error 2



Erik Rijkers